Differentiate share links #36056
Merged
Differentiate share links #36056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
PVince81
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
@Pytal the numbers only appear with the second link, right? So "Share link" will initially not have a number. Then I'm thinking it might be best to cut the " (1)" from the first one and only number from then on, just like we do for filenames. when copying files.
artonge
approved these changes
Jan 10, 2023
Pytal
force-pushed
the
enh/a11y-share-link-index
branch
from
c8866bf to
42399fc
Compare
Pytal
added
4. to release
Pytal
force-pushed
the
enh/a11y-share-link-index
branch
from
42399fc to
1334921
Compare
jancborchardt
approved these changes
Jan 12, 2023
Pytal
force-pushed
the
enh/a11y-share-link-index
branch
from
1334921 to
3bdf383
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-share-link-index
branch
from
3bdf383 to
f09300b
Compare
|
Wording adjusted slightly |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between share links especially when using a screenreader