- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.6k
Add restrictions when downloading to resolve with opengraph link provider #36016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    … resolve with opengraph link provider Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
              
                    nickvergessen
  
              
              approved these changes
              
                  
                    Jan 5, 2023 
                  
              
              
            
            
              
                    miaulalala
  
              
              approved these changes
              
                  
                    Jan 5, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
              
                    juliusknorr
  
              
              approved these changes
              
                  
                    Jan 5, 2023 
                  
              
              
            
            
| Not sure where this comes from:  | 
| @szaimen I don't know either but it's not related. | 
| /backport to stable25 | 
| Failure is also there on master. | 
    
  max-nextcloud 
      added a commit
        to nextcloud/text
      that referenced
      this pull request
    
      Jan 8, 2023 
    
    
      
  
    
      
    
  
* CI passes with Use latest server version that worked on master * Try to revert nextcloud/server#36016 Signed-off-by: Max <max@nextcloud.com>
      
        
      
      
  
    9 tasks
  
      
  
  Closed
  
      
        
      
      
  
    9 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This makes a HEAD request before the GET one and skips links if either:
text/htmlAnother approach would be to use the stream Guzzle option when performing the GET request to avoid the extra HEAD request and either:
stop reading the body after a size limit
I don't know if it makes sense since we probably can't properly parse a partial html content.
directly check the size and type from the headers and skip bad links even before reading the body.
I don't know if the headers are retrieved before downloading/streaming the body.
What do you think?