Skip to content

fix video fullscreen on public page #35897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix video fullscreen on public page #35897

merged 1 commit into from
Dec 28, 2022

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 27, 2022 •
edited
Loading

Fix #35896

Before After
image image

@szaimen szaimen added bug 2. developing Work in progress labels Dec 27, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 27, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Dec 27, 2022

/compile amend /

@szaimen @nextcloud-command
fix video fullscreen on public page
6e3bb03 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/35896/fix-video-fullscreen branch from d00d326 to 6e3bb03 Compare December 27, 2022 15:52
@szaimen szaimen requested review from a team and skjnldsv December 27, 2022 15:56
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 27, 2022
@szaimen szaimen marked this pull request as ready for review December 27, 2022 15:56
@szaimen
Copy link
Contributor Author

szaimen commented Dec 27, 2022

/backport to stable25

artonge
artonge approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, you're on fire this week !

max-nextcloud
max-nextcloud approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@szaimen
Copy link
Contributor Author

szaimen commented Dec 28, 2022

Dang, you're on fire this week !

Thanks 😅

@szaimen szaimen merged commit 84cec5b into master Dec 28, 2022
@szaimen szaimen deleted the fix/35896/fix-video-fullscreen branch December 28, 2022 13:16
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 28, 2022
Merged
1 task
@jdanna
Copy link

jdanna commented Oct 14, 2023

FYI This is still broken on iOS mobile devices - the same behavior as before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: A full screen video in Safari browser of iPhone bacomes blank or tiny size at landscape orientation. (Nextcloud 25)

6 participants

@szaimen @jdanna @artonge @skjnldsv @max-nextcloud