Skip to content

Replace custom tooltips with native ones in files #35795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

Replace custom tooltips with native ones in files #35795

merged 1 commit into from
Dec 23, 2022

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 16, 2022 •
edited
Loading

Summary

to be written

TODO

  • Replace custom tooltips with native ones in files
  • check if implementation in the apps/files/js/mainfileinfodetailview.js is right.
  • check if implementation in the apps/files/js/newfilemenu.js is right.

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 16, 2022
@JuliaKirschenheuter JuliaKirschenheuter added the 2. developing Work in progress label Dec 16, 2022
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review December 21, 2022 15:56
ChristophWurst
ChristophWurst approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

ChristophWurst
ChristophWurst reviewed Dec 21, 2022
View reviewed changes
@JuliaKirschenheuter
Replace custom tooltips with native ones in files
3485450 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35770-Replace_custom_tooltips_with_native_one_for_files branch from cd94a99 to 3485450 Compare December 22, 2022 13:43
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 22, 2022
@ChristophWurst
Copy link
Member

I assume the TODO items can be checked off

@JuliaKirschenheuter JuliaKirschenheuter merged commit f176b3b into master Dec 23, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/35770-Replace_custom_tooltips_with_native_one_for_files branch December 23, 2022 10:54
@ChristophWurst
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BITV]: Replace custom tooltips with native one for files

4 participants

@JuliaKirschenheuter @ChristophWurst @skjnldsv