Skip to content

Fix missing cast of double controller parameters #35780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix missing cast of double controller parameters #35780

merged 1 commit into from
Dec 16, 2022

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 15, 2022 •
edited
Loading

Resolves: N/a

Summary

settype allows 'double' as alias of 'float': https://www.php.net/manual/en/function.settype.php

TODO

  • Fix

Checklist

@ChristophWurst
fix(app framework): Fix missing cast of double controller parameters
b6dd1a1 
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Dec 15, 2022
@ChristophWurst ChristophWurst self-assigned this Dec 15, 2022
@ChristophWurst
Copy link
Member Author

/backport to stable25

@ChristophWurst
Copy link
Member Author

/backport to stable24

@come-nc
Copy link
Contributor

come-nc commented Dec 15, 2022

Does that mean we are using double in our code? Shouldn’t the fix be to replace by float?

@ChristophWurst
Copy link
Member Author

I fixed this for consistency. We also allow int and integer.

PVince81
PVince81 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit ae6fe87 into master Dec 16, 2022
@PVince81 PVince81 deleted the fix/http-dispatcher-double-parameter-cast branch December 16, 2022 15:18
This was referenced Dec 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@PVince81 PVince81 PVince81 approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@st3iny st3iny Awaiting requested review from st3iny

@brantje brantje Awaiting requested review from brantje

@ddijak ddijak Awaiting requested review from ddijak

@julien-nc julien-nc Awaiting requested review from julien-nc

@zak39 zak39 Awaiting requested review from zak39

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews technical debt

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst @come-nc @rullzer @PVince81