Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Dec 10, 2022

Fix #35690

Non-breaking version of #35165 which had to be reverted for reasons described in #35665

While each consecutive :not() pseudo-class adds to the specificity of the CSS rule, using a comma-separated list of selectors instead reduces the specificity to that of only the most specific selector in the list, see MDN docs

  • Verify that styles of non-NcSelect* components in @nextcloud/vue remain unchanged
  • Verify that styles of server settings and files pages remain unchanged

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug 3. to review Waiting for reviews labels Dec 10, 2022
@Pytal Pytal added this to the Nextcloud 26 milestone Dec 10, 2022
@Pytal Pytal self-assigned this Dec 10, 2022
@Pytal
Copy link
Member Author

Pytal commented Dec 10, 2022

/backport to stable25

@skjnldsv
Copy link
Member

While each consecutive :not() pseudo-class adds to the specificity of the CSS rule, using a comma-separated list of selectors instead reduces the specificity to that of only the most specific selector in the list, see MDN docs

Oooh, I didn't know that! Nice @Pytal
Thanks for the explanations :)

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2022
@Pytal Pytal merged commit f503712 into master Dec 12, 2022
@Pytal Pytal deleted the fix/vue-select-styles-the-sequel branch December 12, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt] Global interactive element styles override scoped Vue styles

4 participants