Skip to content

[stable25] Add new border color variable and adjust primary color for increased contrast #35640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2022
Merged

[stable25] Add new border color variable and adjust primary color for increased contrast #35640

merged 2 commits into from
Dec 14, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Dec 7, 2022

Backport #35549

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Dec 7, 2022
@Pytal Pytal added this to the Nextcloud 25.0.3 milestone Dec 7, 2022
@Pytal Pytal self-assigned this Dec 7, 2022
@Pytal Pytal mentioned this pull request Dec 7, 2022
Merged
@Pytal Pytal changed the title [stable25] Add new border color variable for increased contrast [stable25] Add new border color variable and adjust primary color for increased contrast Dec 7, 2022
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 7, 2022
@Pytal
Copy link
Member Author

Pytal commented Dec 8, 2022

/rebase

@Pytal Pytal force-pushed the backport/35549/stable25 branch from 32981ed to 35e7dc5 Compare December 13, 2022 01:50
@Pytal
Copy link
Member Author

Pytal commented Dec 13, 2022

Fixed tests

Pytal added 2 commits December 13, 2022 23:01
@Pytal
Add new border color variable for increased contrast
2e68e8e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 24ffe32)
@Pytal
Lighten default color slightly for increased contrast
bf0af98 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 1c753c2)
@Pytal Pytal force-pushed the backport/35549/stable25 branch from 35e7dc5 to bf0af98 Compare December 13, 2022 23:02
@Pytal
Copy link
Member Author

Pytal commented Dec 14, 2022

CI failure unrelated

@Pytal Pytal merged commit 5922fdd into stable25 Dec 14, 2022
@Pytal Pytal deleted the backport/35549/stable25 branch December 14, 2022 00:14
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility

Projects

None yet

Milestone

Nextcloud 25.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal @AndyScherzinger @JuliaKirschenheuter