Skip to content

[stable25] Set page titel for each sidebar section through User management pages #35467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

[stable25] Set page titel for each sidebar section through User management pages #35467

merged 1 commit into from
Dec 16, 2022

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 28, 2022 •
edited by Pytal
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #35257

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.2 milestone Nov 28, 2022
@Pytal
Copy link
Member

Pytal commented Nov 28, 2022

/compile amend /

@blizzz blizzz mentioned this pull request Nov 29, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Nov 29, 2022

moved to 25.0.3

@JuliaKirschenheuter JuliaKirschenheuter added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 9, 2022
@ChristophWurst
Copy link
Member

conflicts

ChristophWurst
ChristophWurst approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good. CI is happy. You can do the final squash.

@JuliaKirschenheuter
Adapt router.js for setting document title.
6f456ba 
Adapt store to store Promise for dynamic requested categories.
Create new constants file to store category name with associated translation.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 16, 2022
@PVince81 PVince81 merged commit 365145a into stable25 Dec 16, 2022
@PVince81 PVince81 deleted the backport/35257/stable25 branch December 16, 2022 16:01
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility bug

Projects

None yet

Milestone

Nextcloud 25.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal @blizzz @ChristophWurst @JuliaKirschenheuter @PVince81