Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Nov 24, 2022

After #35009, the copy of elements that are not Node will fail.

This PR considers that non Node objects are not subject to quota limitation, and therefore should not be blocked.

It would be ok to limit the change to the parentNode only.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added this to the Nextcloud 26 milestone Nov 24, 2022
@artonge
Copy link
Contributor Author

artonge commented Nov 24, 2022

/backport to stable25

@artonge
Copy link
Contributor Author

artonge commented Nov 24, 2022

/backport to stable24

@artonge
Copy link
Contributor Author

artonge commented Nov 24, 2022

/backport to stable23

@artonge artonge self-assigned this Nov 24, 2022
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 24, 2022
@artonge artonge enabled auto-merge November 24, 2022 11:01
@artonge artonge merged commit 6502e3c into master Nov 24, 2022
@artonge artonge deleted the artonge/fix/dont_error_when_destination_is_not_a_node branch November 24, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants