Remove potential mismatching dav session data during login #35318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
a team,
ArtificialOwl,
PVince81,
blizzz,
icewind1991 and
skjnldsv
and removed request for
a team
skjnldsv
approved these changes
Nov 22, 2022
|
Do we have a list of all those fancy session constants? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make sure that whenever a session is being reused during login we properly clean up the dav session data which is only required to prioritise basic auth over the session login on WebDAV. (ref owncloud/core#13245)
We can safely reset this if the session id is being regenerated during login.
The issue never occurred in the wild as far as I can see but was just a side effect of the cypress tests in viewer that reused the cookie jar that was used for userA webdav requests to run a login and e2e test for userB.
See #34934 (comment) for more technical insights.