Fix border color contrast #35315
Merged
Fix border color contrast #35315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
requested review from
jancborchardt,
nickvergessen,
nimishavijay and
skjnldsv
|
/backport to stable25 |
skjnldsv
approved these changes
Nov 22, 2022
Tests fail |
AndyScherzinger
approved these changes
Nov 22, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-border-contrast
branch
from
4d2a9b1 to
a0266d1
Compare
Pytal
added
4. to release
This was referenced Nov 23, 2022
|
@Pytal theming tests are failing on master now, please fix them. I'll ignore them for now as we need to ship the RC soon. |
Rather, They are failing on Fixed in #35415 |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Border color contrast requirements
To meet WCAG AA contrast requirements for border colors, categorized under “Graphical Objects and User Interface Components”, a minimum 3:1 foreground-background contrast ratio is required
Primary color borders
Original color is lightened slightly
#00639a→#006aa3Before/After contrast ratios
Dark mode
Light mode
General-purpose borders
Dark mode
--color-border:#292929→#646464--color-border-dark:#3b3b3b→#787878(greater contrast on dark backgrounds due to being lighter than--color-border)Light mode
--color-border:#ededed→#949494--color-border-dark:#dbdbdb→#808080(greater contrast on light backgrounds due to being darker than--color-border)Before/After contrast ratios
Dark mode
Light mode
Examples
Primary + general border colors
General border color usage