Skip to content

Conversation

@PVince81
Copy link
Member

Fixes #32354

Fixes issue when cancelling a long list of uploads.

Fixes issue when cancelling a long list of uploads.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

/backport to stable25

@PVince81
Copy link
Member Author

/backport to stable24

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

Finally a fix was found 🎉🎉🎉

@szaimen
Copy link
Contributor

szaimen commented Nov 18, 2022

/backport to stable23

@skjnldsv
Copy link
Member

Touching legacy upload code ? 👻 😁

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 18, 2022
@PVince81
Copy link
Member Author

Touching legacy upload code ? ghost grin

I had no choice 🧤

and just now looking at the history I realized that the line this.data.abort() was already there 7 years ago and got lost somehow 🙀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to cancel upload that contains a lot of files and/or folders

4 participants