generate user themed icons

[szaimen]

Close #34654

Signed-off-by: Simon L szaimen@e.mail.de

For my own testing

docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
-e SERVER_BRANCH=enh/34654/try-go-generate-user-themed-icons \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

[skjnldsv]

To simplify the code, I would put a getCacheBuster method in
https://github.com/nextcloud/server/blob/99191167167dd6c98dc3ae9b0eca947526e7939f/apps/theming/lib/Util.php

And use it from here.
You can then benefit from the dependency injection of the Util class.

[szaimen]

Just tested again and there seem to be some issue with the admin disabling user theming. So this needs to be verified as well...

[szaimen]

This works now and is ready for re-review :)

[skjnldsv]

Please also directly integrate the system cachebuster into the Util

server/apps/theming/lib/Service/ThemeInjectionService.php

Lines 90 to 96 in abaa3ef

	$cacheBuster = $this->config->getAppValue('theming', 'cachebuster', '0');
	if ($this->userId !== null) {
	// need to bust the cache for the CSS file when the user background changed as its
	// URL is served in those files
	$userCacheBuster = $this->config->getUserValue($this->userId, Application::APP_ID, 'userCacheBuster', '0');
	$cacheBuster .= $this->userId . '_' . $userCacheBuster;
	}

That way we can standardise and use $this->util->getCacheBuster() in ThemeInjectionService too

#34654 (comment)

[szaimen]

@skjnldsv @come-nc do you know how I can fix these tests? I don't get it :/

hopefully fixed

[szaimen]

@skjnldsv @come-nc the same nodb test is still failing. Can someone please help me to fix it? Is maybe a mock missing or something? See