Skip to content

[LDAP] always create instance of own user manager #35070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2022
Merged

[LDAP] always create instance of own user manager #35070

merged 1 commit into from
Nov 13, 2022

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Nov 10, 2022

  • it is config specific and cannot be shared
  • because the Access instance is bound later, it is not obvious from the constructor

fixes #34993

@blizzz
[LDAP] always create instance of own user manager
e6e18b4 
- it is config specific and cannot be shared
- because the Access instance is bound later, it is not obvious from the
  constructor

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 26 milestone Nov 10, 2022
@blizzz blizzz requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a team November 10, 2022 09:34
@blizzz
Copy link
Member Author

blizzz commented Nov 10, 2022

/backport to stable25

@blizzz
Copy link
Member Author

blizzz commented Nov 10, 2022

/backport to stable24

@blizzz blizzz mentioned this pull request Nov 10, 2022
Closed
9 tasks
@blizzz blizzz requested a review from artonge November 10, 2022 09:41
szaimen
szaimen approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 10, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2022

Merge or do we wanna wait for the feedback?

@blizzz
Copy link
Member Author

blizzz commented Nov 10, 2022

Merge or do we wanna wait for the feedback?

Let's see tomorrow.

@michel-nicol
Copy link

I tested this patch on the third Nextcloud server I'm administering, which I kept back at 24.0.6. I upgraded to 24.0.7 using the updater and then replaced Application.php with the proposed version, and all worked flawlessly.

@szaimen
Copy link
Contributor

szaimen commented Nov 13, 2022

Great! Thanks for veryfying :)

@szaimen szaimen merged commit 8af36bf into master Nov 13, 2022
@szaimen szaimen deleted the fix/34993/ldap-user-manager-must-not-be-shared branch November 13, 2022 22:13
This was referenced Nov 13, 2022
Merged
Merged
@aknauss
Copy link

aknauss commented Mar 28, 2023

Hi,
It seems that bug with two ldap is here on Nextcloud 26...
How can I do to patch this version?

Thanks a lot.
Franck

@come-nc come-nc mentioned this pull request Apr 24, 2023
Merged
4 tasks
@chritd
Copy link

chritd commented May 4, 2023

same problem after upgrading to 26.
is there already a fix?
many thx

@szaimen
Copy link
Contributor

szaimen commented May 4, 2023

Should be fixed with 26.0.2

@florian-obradovic
Copy link

florian-obradovic commented May 24, 2023 •
edited
Loading

Fix with the current commit:

Backup

cd /var/www/nextcloud/apps

cp -rfv user_ldap ~/user_ldap-BACKUP

cd /var/www/nextcloud/apps/user_ldap/lib

sudo rm AccessFactory.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/lib/AccessFactory.php

sudo rm Sync.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/lib/Jobs/Sync.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/tests/Jobs/SyncTest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen approved these changes

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@artonge artonge Awaiting requested review from artonge

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap regression

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: User cannot authenticate with LDAP backend if multiple LDAP servers are configured

9 participants

@blizzz @szaimen @michel-nicol @aknauss @chritd @florian-obradovic @CarlSchwan @come-nc