Skip to content

Bump aws/aws-sdk-php to 3.240 #34943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump aws/aws-sdk-php to 3.240 #34943

wants to merge 1 commit into from

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 3, 2022 •
edited
Loading

@come-nc come-nc added the 3. to review Waiting for reviews label Nov 3, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Nov 3, 2022
@come-nc come-nc self-assigned this Nov 3, 2022
szaimen
szaimen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc requested review from a team, ArtificialOwl, PVince81, juliusknorr and kesselb and removed request for a team November 3, 2022 14:22
PVince81
PVince81 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after rebase/adjusting commit id

@come-nc come-nc marked this pull request as ready for review November 3, 2022 16:02
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

+1 after rebase/adjusting commit id

Done, waiting on CI.

@come-nc come-nc force-pushed the fix/bump-aws/aws-sdk-php-to-3.240 branch from 5c2fb21 to c0963be Compare November 3, 2022 16:06
@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

+1 after rebase/adjusting commit id

Done, waiting on CI.

@come-nc come-nc enabled auto-merge November 3, 2022 16:55
@szaimen
Copy link
Contributor

szaimen commented Nov 4, 2022

Not sure but seems like autoloaders are not up-to-date?

@come-nc
Copy link
Contributor Author

come-nc commented Nov 7, 2022

/rebase

@come-nc
Bump aws/aws-sdk-php to 3.240
e7a899f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/bump-aws/aws-sdk-php-to-3.240 branch from c0963be to e7a899f Compare November 7, 2022 08:26
@come-nc
Copy link
Contributor Author

come-nc commented Nov 7, 2022

autoloaders are good but this look like real trouble:
https://drone.nextcloud.com/nextcloud/server/25410/66/4

@come-nc come-nc mentioned this pull request Nov 7, 2022
Merged
2 tasks
@come-nc come-nc closed this Nov 7, 2022
auto-merge was automatically disabled November 7, 2022 13:34

Pull request was closed

@szaimen
Copy link
Contributor

szaimen commented Nov 7, 2022

@come-nc should we revert nextcloud/3rdparty#1210?

@szaimen szaimen deleted the fix/bump-aws/aws-sdk-php-to-3.240 branch November 7, 2022 13:37
@come-nc
Copy link
Contributor Author

come-nc commented Nov 7, 2022

@come-nc should we revert nextcloud/3rdparty#1210?

No, it was merged with #34996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@come-nc @szaimen @PVince81