Conversation
Member
MorrisJobke
commented
Feb 14, 2017
MorrisJobke
commented
- fixes App name in Files app says »Apps« instead of »Files« #3479
MorrisJobke
requested review from
LukasReschke,
blizzz,
jancborchardt,
nickvergessen and
skjnldsv
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers. |
MorrisJobke
force-pushed
the
fix-files-header-name
branch
from
20c3d7e to
a804ddb
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-files-header-name
branch
from
a804ddb to
b954c2f
Compare
MorrisJobke
commented
Feb 14, 2017
| $params['fileNotFound'] = $fileNotFound ? 1 : 0; | ||
| $params['appNavigation'] = $nav; | ||
| $params['appContents'] = $contentItems; | ||
| $this->navigationManager->setActiveEntry('files_index'); |
Member
Author
There was a problem hiding this comment.
This is the actual fix. The rest is just cleanup of unneeded code due to this change 😉
skjnldsv
approved these changes
Feb 15, 2017
Member
|
Test restarted |
Codecov Report
@@ Coverage Diff @@
## master #3487 +/- ##
===========================================
+ Coverage 54.14% 54.2% +0.06%
- Complexity 21020 21040 +20
===========================================
Files 1306 1306
Lines 80246 80371 +125
Branches 1250 1250
===========================================
+ Hits 43447 43563 +116
- Misses 36799 36808 +9
Continue to review full report at Codecov.
|
blizzz
approved these changes
Feb 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.