Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Add a repair step to cleanup old theming cache #34647

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[stable25] Add a repair step to cleanup old theming cache #34647

merged 1 commit into from
Oct 20, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 18, 2022 •
edited by Pytal
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #34620

@backportbot-nextcloud backportbot-nextcloud bot added bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: theming labels Oct 18, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25 milestone Oct 18, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label Oct 19, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 25.0.1 Oct 19, 2022
@blizzz
Copy link
Member

blizzz commented Oct 19, 2022

backport incomplete

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 19, 2022
@Pytal
Add a repair step to cleanup old theming cache
cdf6e03 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal self-assigned this Oct 20, 2022
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 20, 2022
PVince81
PVince81 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if my concern is obsolete

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 20, 2022
@Pytal Pytal merged commit 271ceb0 into stable25 Oct 20, 2022
@Pytal Pytal deleted the backport/34620/stable25 branch October 20, 2022 17:04
@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@Pytal Pytal Pytal approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: theming
Projects
None yet
Milestone
Nextcloud 25.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @PVince81 @skjnldsv @Pytal