Skip to content

Conversation

@CarlSchwan
Copy link
Member

Otherwise we detect a email change all the time and since email are immutable in ldap this prevent updating other fields.

Related: #33813

Signed-off-by: Carl Schwan carl@carlschwan.eu

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Oct 17, 2022
@CarlSchwan CarlSchwan self-assigned this Oct 17, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Oct 17, 2022
@CarlSchwan
Copy link
Member Author

/backport to stable25

@CarlSchwan
Copy link
Member Author

/backport to stable24

@CarlSchwan
Copy link
Member Author

/backport to stable23

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why is #33813 not enough ?

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Nov 4, 2022

add a unit test for this ?

CarlSchwan and others added 2 commits December 16, 2022 17:47
Otherwise we detect a email change all the time and since email are
immutable in ldap this prevent updating other fields.

Related: #33813

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the fix/case-sensitivity-email-ldap branch from ef97425 to f9ea078 Compare December 16, 2022 16:47
@PVince81
Copy link
Member

rebased and added a unit test

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 16, 2022
@PVince81 PVince81 enabled auto-merge December 16, 2022 16:57
@PVince81 PVince81 merged commit 346f990 into master Dec 16, 2022
@PVince81 PVince81 deleted the fix/case-sensitivity-email-ldap branch December 16, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants