fix logo not correctly inverted #34615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
reviewed
Oct 14, 2022
9 tasks
szaimen
commented
Oct 18, 2022
szaimen
added
2. developing
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
enh/noid/logo-inverted
branch
from
4489f28 to
975174a
Compare
|
Done, please check @szaimen |
skjnldsv
force-pushed
the
enh/noid/logo-inverted
branch
from
975174a to
26ea38d
Compare
skjnldsv
approved these changes
Nov 8, 2022
skjnldsv
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
reviewed
Nov 8, 2022
szaimen
commented
Nov 8, 2022
|
@skjnldsv sorry for bothering you but could you maybe take another look at this? I think we need to get the value from the our default themes by checking against its dark value... |
43 tasks
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/noid/logo-inverted
branch
from
22fe22e to
e6b7fa6
Compare
My bad, wrong fallback value! 👍 |
szaimen
commented
Nov 16, 2022
|
/backport to stable25 |
1 task
|
The backport to stable25 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #34656
Signed-off-by: szaimen szaimen@e.mail.de