Skip to content

Fix password length limitation #34500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix password length limitation #34500

merged 2 commits into from
Oct 11, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 10, 2022

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Fix password length limitation
ab05541 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Oct 10, 2022
@nickvergessen nickvergessen requested review from a team October 10, 2022 10:35
@nickvergessen nickvergessen self-assigned this Oct 10, 2022
@nickvergessen nickvergessen requested review from CarlSchwan, Pytal, artonge, blizzz, icewind1991 and szaimen and removed request for a team October 10, 2022 10:35
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

/compile /

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

/backport ab05541 to stable25

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

/backport ab05541 to stable24

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

/backport ab05541 to stable23

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

/backport ab05541 to stable22

@nextcloud-command
Compile assets
a576513 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
blizzz
blizzz approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferably 469 goes into a const, but acceptable.

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2022

Probably should in a follow up across the board.

server/apps/settings/lib/Controller/ChangePasswordController.php

Line 98 in 60c4291

if ($newpassword === null || strlen($newpassword) > 469 || $user->setPassword($newpassword) === false) {

For now magic number to improve backportability

artonge
artonge approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented somewhere ?

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2022
@nickvergessen nickvergessen merged commit 719c9c3 into master Oct 11, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/more-password-limitation branch October 11, 2022 11:32
This was referenced Oct 11, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@nickvergessen nickvergessen

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @blizzz @artonge @szaimen @nextcloud-command