Skip to content

Fix excessive increase of cachebuster value #34473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix excessive increase of cachebuster value #34473

merged 1 commit into from
Oct 11, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Oct 8, 2022

Fix #34457

@Pytal Pytal added bug 3. to review Waiting for reviews feature: theming regression feature: caching Related to our caching system: scssCacher, jsCombiner... labels Oct 8, 2022
@Pytal Pytal added this to the Nextcloud 26 milestone Oct 8, 2022
@Pytal Pytal self-assigned this Oct 8, 2022
@nickvergessen
Copy link
Member

Tests fail:

TypeError: Argument 6 passed to OCA\Theming\Controller\UserThemeController::__construct() must be an instance of OCA\Theming\ThemingDefaults, instance of Mock_BackgroundService_9c6977f9 given, called in /drone/src/apps/theming/tests/Controller/UserThemeControllerTest.php on line 94

@blizzz
Copy link
Member

blizzz commented Oct 10, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Oct 10, 2022

Alternative fix in #34437
IIRC

@szaimen szaimen closed this Oct 10, 2022
@szaimen szaimen reopened this Oct 10, 2022
@blizzz
Copy link
Member

blizzz commented Oct 10, 2022

Alternative fix in #34437 IIRC

very brief look seems it suffers of the same problem, but i really only spend two seconds on it.

@szaimen
Copy link
Contributor

szaimen commented Oct 10, 2022

@Pytal can you please fix the tests? :)

@blizzz blizzz mentioned this pull request Oct 11, 2022
Merged
@Pytal
Fix excessive increase of cachebuster value
46ee620 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/excessive-increase-cachebuster branch from 2efa17d to 46ee620 Compare October 11, 2022 16:26
szaimen
szaimen approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen
Copy link
Contributor

szaimen commented Oct 11, 2022

CI failure unrelated

@szaimen szaimen merged commit dc9cd22 into master Oct 11, 2022
@szaimen szaimen deleted the fix/excessive-increase-cachebuster branch October 11, 2022 19:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen szaimen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: theming regression

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: cachebuster value rising infinitely

5 participants

@Pytal @nickvergessen @blizzz @szaimen