Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PHPUnit version #34416

Closed
wants to merge 1 commit into from
Closed

Adjust PHPUnit version #34416

wants to merge 1 commit into from

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Oct 3, 2022

This kills the Drone

@miaulalala miaulalala added the 3. to review Waiting for reviews label Oct 3, 2022
@miaulalala miaulalala self-assigned this Oct 3, 2022
@nickvergessen
Copy link
Member

Drone images run 8.5 :/

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  - UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3, "size" = CASE WHEN "size" > '-1' THEN MAX("size" + :dcValue4, :dcValue5) ELSE "size" END WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3 WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "size" = MAX("size" + :dcValue1, :dcValue2) WHERE ("storage" = :dcValue3) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1')) AND ("size" > '-1')
= /remote.php/dav/files/test/new_file.txt

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 4, 2022
@max-nextcloud
Copy link
Contributor

rebased and resolved the conflict. No idea if drone these days can provide phpunit >9.5... i guess we'll see from the CI run.

@max-nextcloud
Copy link
Contributor

grafik
memcached test is the only one failing on this right now.

@come-nc
Copy link
Contributor

come-nc commented Mar 20, 2023

memcached test is the only one failing on this right now.

  image: ghcr.io/nextcloud/continuous-integration-php8.0-memcached:latest

The problem must be in this image then.

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 17, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

/rebase

@szaimen szaimen enabled auto-merge April 17, 2023 14:42
Signed-off-by: Anna Larch <anna@nextcloud.com>
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

I updated the image. Lets see if another rebase fixes this now.

@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@szaimen szaimen disabled auto-merge April 17, 2023 21:06
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2023
This was referenced May 3, 2023
@nickvergessen
Copy link
Member

Done via 3294bbe in the meantime

@skjnldsv skjnldsv deleted the enh/reality-adjustment branch March 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants