Skip to content

Only match http(s) URLs for references #34322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2022
Merged

Only match http(s) URLs for references #34322

merged 2 commits into from
Sep 30, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Sep 29, 2022
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Sep 29, 2022
@nickvergessen nickvergessen requested review from a team, icewind1991, juliusknorr, max-nextcloud and skjnldsv and removed request for a team September 29, 2022 09:14
@szaimen
Copy link
Contributor

szaimen commented Sep 29, 2022

image

@nickvergessen
Only match http(s) URLs for references
474dcf0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/limit-url-matching-to-https branch from d551dda to 474dcf0 Compare September 29, 2022 09:29
szaimen
szaimen approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 29, 2022
@blizzz blizzz mentioned this pull request Sep 29, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 29, 2022
@blizzz
Copy link
Member

blizzz commented Sep 29, 2022 •
edited
Loading

master is still 26, please trigger a backport if necessary

@juliusknorr
Copy link
Member

/backport to stable25

@juliusknorr
Copy link
Member

JSunit would need some adjustments for comments to not match nextcloud.com anymore

  1. should parse URLs only
    OCP.Comments tests
    Expected 'nextcloud.com' to equal 'nextcloud.com'.
    at core/js/tests/specs/public/commentsSpec.js:48:19
    at Array.forEach ()
    at Object. (core/js/tests/specs/public/commentsSpec.js:46:18)
    Expected 'hi nextcloud.com' to equal 'hi nextcloud.com'.
    at core/js/tests/specs/public/commentsSpec.js:48:19
    at Array.forEach ()
    at Object. (core/js/tests/specs/public/commentsSpec.js:46:18)
    Expected 'nextcloud.com foobar' to equal 'nextcloud.com foobar'.
    at core/js/tests/specs/public/commentsSpec.js:48:19
    at Array.forEach ()
    at Object. (core/js/tests/specs/public/commentsSpec.js:46:18)
    Expected 'hi nextcloud.com foobar' to equal 'hi nextcloud.com foobar'.
    at core/js/tests/specs/public/commentsSpec.js:48:19
    at Array.forEach ()
    at Object. (core/js/tests/specs/public/commentsSpec.js:46:18)
    Expected 'hi help.nextcloud.com/category/topic foobar' to equal 'hi help.nextcloud.com/category/topic foobar'.
    at core/js/tests/specs/public/commentsSpec.js:48:19
    at Array.forEach ()
    at Object. (core/js/tests/specs/public/commentsSpec.js:46:18)

@nickvergessen
Adjust tests
f976d37 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Fixed

@juliusknorr juliusknorr merged commit 27ce4bd into master Sep 30, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/limit-url-matching-to-https branch September 30, 2022 06:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @szaimen @blizzz @juliusknorr @skjnldsv