-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add color variables for text on blurred background #34299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
master is still 26, please trigger a backport if necessary |
It should be dispatched to the DarkTheme.php as well as there is a darken usage (so should be lighten on dark themes) |
8136c36 to
2558bf0
Compare
2558bf0 to
e69abfb
Compare
|
/backport to stable25 |
e69abfb to
888d35b
Compare
|
This is important for accessibility, could you review @skjnldsv @szaimen @juliushaertl @marcoambrosini? :) |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
888d35b to
8c4de8f
Compare
|
Also made sure that text remains high contrast in high contrast modes |
Adds variables required for nextcloud-libraries/nextcloud-vue#3307
Compared to
--color-text-maxcontrastthe new--color-text-maxcontrast-background-bluris darker in light mode and lighter in dark modeLight mode:
#767676->#646464Dark mode:
#8C8C8C->#919191