Skip to content

Improve bulk upload and add a config switch for it #33697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 30, 2022
Merged

Improve bulk upload and add a config switch for it #33697

merged 9 commits into from
Aug 30, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 25, 2022

Fix #33691

come-nc added 2 commits August 25, 2022 14:47
@come-nc
Add fileid and permissions to response of bulk upload
be7082e 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add bulkupload.enabled configuration switch
5ae185a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 25 milestone Aug 25, 2022
@come-nc come-nc self-assigned this Aug 25, 2022
@come-nc come-nc requested a review from mgallien August 25, 2022 13:01
szaimen
szaimen reviewed Aug 25, 2022
View reviewed changes
apps/dav/lib/Capabilities.php Outdated
// 'bulkupload' => '1.0',
]
];
if ($this->config->getSystemValueBool('bulkupload.enabled', false)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... I think the idea was to enable it by default.

cc @PVince81

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but it needs to be confirmed working first :-P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set it to true at least for master, if we're optimistic 😄

we can then delay the backports until proven stable

mgallien
mgallien requested changes Aug 26, 2022
View reviewed changes
@mgallien
Copy link
Contributor

matching pull request on desktop client side nextcloud/desktop#4869

@mgallien mgallien mentioned this pull request Aug 26, 2022
Merged
@come-nc
Call the correct functions to get BulkUpload metadata to return
e34f2c4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2022
View reviewed changes
@come-nc come-nc force-pushed the fix/improve-bulk-upload branch from 036fd8c to 16ea85f Compare August 29, 2022 08:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2022
View reviewed changes
@come-nc come-nc force-pushed the fix/improve-bulk-upload branch from 16ea85f to 53a02fc Compare August 29, 2022 09:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2022
View reviewed changes
@come-nc
Move Dav fileid and permissions logic into OCP\Util to be able to use…
b3cd9b5 
… it for BulkUpload

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/improve-bulk-upload branch from 53a02fc to b3cd9b5 Compare August 29, 2022 11:55
@come-nc come-nc requested a review from mgallien August 29, 2022 12:27
@come-nc come-nc added the 3. to review Waiting for reviews label Aug 29, 2022
mgallien
mgallien approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
works nicely

come-nc added 2 commits August 29, 2022 15:19
@come-nc
Fix OCP\Util documentation blocks
d90b314 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix Capabilities tests for dav application
9874557 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor Author

come-nc commented Aug 29, 2022

Remaining test failure unrelated.

@come-nc
Flip bulkupload.enabled default value to true
7f80dcc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
CarlSchwan
CarlSchwan reviewed Aug 29, 2022
View reviewed changes
@come-nc
Move dav utils functions to OCP\Files\DavUtil
4f3b323 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/improve-bulk-upload branch from 819c11c to 4f3b323 Compare August 30, 2022 07:58
@come-nc
Add DavUtil to autoloader
30bfd5f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit 6664801 into master Aug 30, 2022
@come-nc come-nc deleted the fix/improve-bulk-upload branch August 30, 2022 10:22
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 30, 2022
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@appliedbarrel appliedbarrel mentioned this pull request Oct 26, 2022
Closed
@joshtrichards joshtrichards mentioned this pull request Sep 16, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen left review comments

@mgallien mgallien mgallien approved these changes

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

Improve bulk upload protocol

5 participants

@come-nc @mgallien @PVince81 @CarlSchwan @szaimen