-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of new user and display the correct error message #33625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The problem itself is present on 24 and 23 too. I guess it's kinda hard to backport the api changes. However the issue only occurs when userId = displayName so the impact is hopefully not to big.
c300eb2
to
85b1909
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
85b1909
to
d595859
Compare
👍 |
should we backport this one to stable24 ? |
We don't backport public API changes though? |
Fix #33572
Out-of-scope
Rollback user creation on other exceptions