Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Change plural to singular #33519

Merged
merged 1 commit into from
Aug 14, 2022
Merged

l10n: Change plural to singular #33519

merged 1 commit into from
Aug 14, 2022

Conversation

rakekniven
Copy link
Member

Here you can select the default theme image, not images.

Reported at Transifex.

Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com

@skjnldsv skjnldsv added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: language l10n and translations labels Aug 12, 2022
@rakekniven
Copy link
Member Author

How to fix the test about the differing map files?

@skjnldsv
Copy link
Member

After rebasing, you can trigger the compile bot like this (see following comments)

@skjnldsv
Copy link
Member

/rebase

@skjnldsv
Copy link
Member

/compile

No! You have to wait for the rebase to make sure your compile action will not have conflicts.
I canceled your run 😉

@skjnldsv
Copy link
Member

skjnldsv commented Aug 14, 2022

Now that you're rebased, you can use the compile (please use amend to avoid creating unnecessary commit)

Compiling action is in https://github.com/nextcloud/server/runs/7825127108

@skjnldsv
Copy link
Member

/compile amend /

Here you can select the default theme image, not images.

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@rakekniven
Copy link
Member Author

Where do I find documentation about this steps?
Are they GitHub features or does Nextcloud define these steps?

@skjnldsv
Copy link
Member

Where do I find documentation about this steps?
Are they GitHub features or does Nextcloud define these steps?

They're Nextcloud tools mostly designed to help and accelerate our processes.
It's not really official or anything 🤷

@skjnldsv skjnldsv merged commit b1e86f3 into master Aug 14, 2022
@skjnldsv skjnldsv deleted the rakekniven-patch-2 branch August 14, 2022 09:38
@rakekniven
Copy link
Member Author

Since years I have seen commands like compile, compile amendor rebase and my searches about details are with nearly no result.
So there is no documentation to read?

@jancborchardt
Copy link
Member

So actually it is intended to be "Default images", as for dark mode there is a different image (maybe not obvious). But since with the next version we are moving away from that, it’s actually correct to use the singular. :) Just for reference @juliushaertl

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: language l10n and translations papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants