Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow symlinks during webpack build #33517

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Allow symlinks during webpack build #33517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cd255
Allow symlinks during webpack build
juliushaertl Aug 12, 2022
d78b82b
Enforce providing jquery from server node_modules
juliushaertl Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ module.exports = {
new VueLoaderPlugin(),
new webpack.ProvidePlugin({
// Provide jQuery to jquery plugins as some are loaded before $ is exposed globally.
jQuery: 'jquery',
// We need to provide the path to node_moduels as otherwise npm link will fail due
// to tribute.js checking for jQuery in @nextcloud/vue
jQuery: path.resolve(path.join(__dirname, 'node_modules/jquery')),
// Shim ICAL to prevent using the global object (window.ICAL).
// The library ical.js heavily depends on instanceof checks which will
// break if two separate versions of the library are used (e.g. bundled one
Expand All @@ -155,7 +157,7 @@ module.exports = {
handlebars: 'handlebars/runtime',
},
extensions: ['*', '.js', '.vue'],
symlinks: false,
symlinks: true,
fallback: {
stream: require.resolve('stream-browserify'),
buffer: require.resolve('buffer'),
Expand Down