Merged
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
ArtificialOwl,
CarlSchwan and
icewind1991
and removed request for
a team
Member
|
note: seems there are laravel updates as well ? make sure these are/were safe |
Contributor
Author
|
I do not understand the current state of 3rdparty submodule on stable24, it does not match stable24 branch of 3rdparty I think, it contains laravel/serializable-closure which was only added in master to my knowledge. |
Member
|
@come-nc maybe someone submit a PR to 3rdparty/stable24 and forgot to update the pointer on stable24 ? you might be able to trace it back |
Contributor
Author
|
I think it is from #33009 |
CarlSchwan
approved these changes
Aug 1, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
the unrelated change are due to the fact that the stable24 3rdparty submodule is not pointing to the correct commit. This commit also fix it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes encoding problems on PHP 8.1
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com