Skip to content

Fix empty address books being exported #33118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix empty address books being exported #33118

merged 1 commit into from
Jul 8, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jul 5, 2022

This prevents empty *.vcf files from being created in <export_archive_root>/dav/address_books/

@Pytal
Fix empty address books being exported
5f31d4b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug 3. to review Waiting for reviews feature: dav feature: carddav Related to CardDAV internals feature: user migration Related to User migration feature: contacts labels Jul 5, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Jul 5, 2022
@Pytal Pytal requested review from a team and tcitworld July 5, 2022 17:07
@Pytal Pytal self-assigned this Jul 5, 2022
@Pytal Pytal requested review from ArtificialOwl, CarlSchwan and blizzz and removed request for a team July 5, 2022 17:07
@Pytal
Copy link
Member Author

Pytal commented Jul 5, 2022

/backport to stable24

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Possible performance regression detected

Show Output 
1 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@blizzz
Copy link
Member

blizzz commented Jul 8, 2022

Possible performance regression detected
Show Output

Seems very much unrelated

@blizzz blizzz merged commit 927b6d6 into master Jul 8, 2022
@blizzz blizzz deleted the fix/address-book-export branch July 8, 2022 20:13
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@tcitworld tcitworld tcitworld approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews bug feature: carddav Related to CardDAV internals feature: contacts feature: dav feature: user migration Related to User migration

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal @blizzz @tcitworld