Skip to content

Conversation

@solracsf
Copy link
Member

Check against PHP version instead of LIBXML version.
Same fix as https://github.com/nextcloud/server/blob/master/lib/private/App/InfoParser.php#L64

"url": "/settings/admin/overview",
  "message": "Function libxml_disable_entity_loader() is deprecated at /app/lib/private/Updater/VersionCheck.php#100",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.115 Safari/537.36",
  "version": "23.0.6.1",
  "exception": {
    "Exception": "Error",
    "Message": "Function libxml_disable_entity_loader() is deprecated at /app/lib/private/Updater/VersionCheck.php#100",
    "Code": 0,
    "Trace": [
      {
        "file": "/app/lib/private/Updater/VersionCheck.php",
        "line": 100,
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::",
        "args": [
          8192,
          "Function libxml_disable_entity_loader() is deprecated",
          "/app/lib/private/Updater/VersionCheck.php",
          100
        ]
      },

@solracsf solracsf added this to the Nextcloud 25 milestone Jun 24, 2022
@solracsf solracsf added the 3. to review Waiting for reviews label Jun 24, 2022
@solracsf
Copy link
Member Author

/backport to stable24

@solracsf
Copy link
Member Author

/backport to stable23

@solracsf
Copy link
Member Author

/backport to stable22

@kesselb
Copy link
Collaborator

kesselb commented Jun 25, 2022

Hi,

Afaik the check against libxml is better because older php versions may use a newer libxml version too: c3a1a66 / sabre-io/xml#204

"version": "23.0.6.1",

That's the problem. I don't think we backported this fix to 23.

@solracsf
Copy link
Member Author

Oh, i see. I'll try to backport the portable commits of that large PR :)

@solracsf solracsf closed this Jun 26, 2022
@solracsf solracsf deleted the libxml-updater branch June 26, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants