Revert "Revert "Remove inefficient fed share scanner""#32852
Merged
Revert "Revert "Remove inefficient fed share scanner""#32852
Conversation
Member
Author
Member
Author
|
@icewind1991 what do you think of disabling the locking as the original federated shares also didn't have locking and this is causing some issues? |
Member
|
Having an integration test for the failing case from #31554 would be good I think. There is one that looks like it could catch that but the file upload part is commented out f6a1286#diff-3d1fc871fd7bb42743321aa17f6abae00336d14755e5992ee3d5c34890c685eeR243-R245 |
8 tasks
This reverts commit 6667007. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
The old inneficiant code didn't do locking and adding locking is creating issues Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
revert-revert-federation-performance-issues
branch
from
4f52670 to
8367b99
Compare
Member
|
The external scanner wasn't respecting the updater's request to disable locking (as the updater is triggered while we already have an exclusive lock) fix is added to the PR. With this I can upload to fed. shared without issue |
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
come-nc
approved these changes
Aug 4, 2022
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6667007.
See context in #32806, this is breaking things
Fixes #31554