handle stream wrappers in SeekableHttpStream #32767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
CarlSchwan,
PVince81,
blizzz and
juliusknorr
and removed request for
a team
|
/backport to stable24 |
|
/backport to stable23 |
CarlSchwan
approved these changes
Jun 8, 2022
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
juliusknorr
approved these changes
Jun 9, 2022
This was referenced Jun 9, 2022
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
SeekableHttpStream'sopenCallbackreturns a stream wrapper, thestream_get_meta_datacall returns the wrapper, not the http headers we're looking for.This changes it to try and get the source of the stream so we can get the http headers.
Additionally I'll look if it's possible to make the wrappers transparent for
stream_get_meta_data