Fix docker image naming issue for CI

[MorrisJobke]

• wrongly named PHP7 - it is PHP 5.6
• moved integration tests at the very end

cc @rullzer @LukasReschke @Mar1u5

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke to be a potential reviewer

[nickvergessen]

Error: image morrisjobke/nextcloud-ci-php5.6 not found

Also can we move js tests after unit tests as well?

[icewind1991]

the docker image is still called -php7 from what I can tell, wouldn't that need to be renamed to

[MorrisJobke]

the docker image is still called -php7 from what I can tell, wouldn't that need to be renamed to

I leave it as php7 and simply created a copy (to not break all open PRs). I also created the same images in the nextcloudci account on docker hub.

Let's see if this works now.

[MorrisJobke]

Also can we move js tests after unit tests as well?

I would like to keep it there, as it only took 30 seconds to complete. The next version of drone will most likely support parallel execution of those steps. It will also have a proper UI to differentiate between the jobs.

[rullzer]

What is the reason to use explicit tags?

[MorrisJobke]

To exactly know on which version it was run on. In this case I just "updated" to the latest version because I know it was build successfully. Otherwise the CI could have a "latest" version locally and doesn't fetch the actual "latest" version from docker hub.

[MorrisJobke]

Better safe than sorry and debugging hours for just noticing, that different images are in use.

[rullzer]

fair enough

[nickvergessen]

👍

[rullzer]

LGTM