Skip to content

Add repair command to fix wrong share ownership #32211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 8, 2022
Merged

Add repair command to fix wrong share ownership #32211

merged 8 commits into from
Nov 8, 2022

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 28, 2022

Fix #28503
Follow up of #30791

@artonge artonge added this to the Nextcloud 25 milestone Apr 28, 2022
@artonge artonge self-assigned this Apr 28, 2022
@artonge artonge force-pushed the feat/repair_share_ownership branch from 6b6fc3e to c48053e Compare April 28, 2022 14:15
@XueSheng-GIT XueSheng-GIT mentioned this pull request Apr 29, 2022
Open
PVince81
PVince81 reviewed May 30, 2022
View reviewed changes
PVince81
PVince81 reviewed May 30, 2022
View reviewed changes
@PVince81 PVince81 mentioned this pull request May 30, 2022
Closed
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@PVince81
Copy link
Member

conflict

@PVince81
Copy link
Member

PVince81 commented Sep 28, 2022 •
edited by icewind1991
Loading

  • we should test this with group folders and system-wide external storages (and shares created from there) to make sure we're not messing these up

@PVince81 PVince81 assigned icewind1991 and unassigned artonge Sep 28, 2022
@PVince81
Copy link
Member

@icewind1991 please take over

@icewind1991 icewind1991 force-pushed the feat/repair_share_ownership branch from c48053e to 248a5a9 Compare September 29, 2022 09:22
@icewind1991
Copy link
Member

  • moved to occ command
  • added option to repair for single user only
  • added progressbar
  • verified that shares from groupfolders are ignored

@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 24, 2022
@nextcloud-command nextcloud-command force-pushed the feat/repair_share_ownership branch from ba52f36 to 7890cc9 Compare October 24, 2022 13:02
@PVince81
Copy link
Member

/backport to stable25

@PVince81
Copy link
Member

/backport to stable24

@PVince81
Copy link
Member

PVince81 commented Nov 2, 2022

second review please, this is long overdue

@PVince81 PVince81 mentioned this pull request Nov 3, 2022
Closed
8 tasks
szaimen
szaimen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@PVince81
Copy link
Member

PVince81 commented Nov 3, 2022

@icewind1991 some checkers fail, autoloader likely

artonge and others added 8 commits November 8, 2022 17:13
@artonge @icewind1991
Add repair step to fix wrong share ownership
610e963 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991
move share owner repair to occ command
3d68a52 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@PVince81 @icewind1991
More verbose output for repair share ownership cmd
1be1c23 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@icewind1991
update shares directly in db
8012c85 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
split repairing into two stages to prevent long open transaction
b667797 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
remove no longer needed code
e09fabd 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix repairing non user shares when repairing all shares
7dc8e6a 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
update autoloader
6d8c72c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the feat/repair_share_ownership branch from 7890cc9 to 6d8c72c Compare November 8, 2022 16:14
@szaimen szaimen merged commit 87f4ed5 into master Nov 8, 2022
@szaimen szaimen deleted the feat/repair_share_ownership branch November 8, 2022 17:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 8, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

/backport to stable24

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

/backport to stable23

This was referenced Nov 8, 2022
Merged
Merged
@monsieurhannes
Copy link

Just tried to find documentation about it and ended up here. Anyone who can add it to the docs (as I don't know what it does)?
https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/occ_command.html#maintenance-commands

@pReya pReya mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@icewind1991 icewind1991

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: sharing

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Repair step for invalid oc_share.uid_owner values

8 participants

@artonge @PVince81 @icewind1991 @mgallien @szaimen @monsieurhannes @blizzz @skjnldsv