Fix dark theme primary mix #32146
Merged
Fix dark theme primary mix #32146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skjnldsv
commented
Apr 26, 2022
skjnldsv
commented
| Before | After |
|---|---|
 |
 |
skjnldsv
requested review from
a team,
Pytal,
artonge,
nickvergessen and
szaimen
and removed request for
a team
skjnldsv
added
design
nickvergessen
approved these changes
Apr 26, 2022
nickvergessen
added
4. to release
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/dark-theme
branch
from
10003ed to
dc6a99d
Compare
szaimen
previously requested changes
Apr 26, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
On the screenshot the new accent color is nearly not visible in contrast to the surroundings espwcially in dark mode. Can we add a bit more contrast there?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/dark-theme
branch
from
dc6a99d to
4dc96dd
Compare
jancborchardt
approved these changes
Apr 26, 2022
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good as fix, but yes let’s improve the contrast on dark mode as follow-up, issue at #32150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.