Scrutinizer fixes

[icewind1991]

Lets try making scrutinizer a bit happier

Contains one or two things which might have actually caused issues previously

[mention-bot]

@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jmaciasportela, @rullzer, @schiessle, @DeepDiver1975 and @Xenopathic to be potential reviewers

[nickvergessen]

you mean @global ?

[nickvergessen]

Looks good, but the change in the ShareController looks a bit intrusive

[nickvergessen]

Needs to be protected

PHP Fatal error: Cannot access private property OCA\DAV\Server::$server in /drone/src/github.com/nextcloud/server/apps/dav/tests/unit/ServerTest.php

[icewind1991]

@nickvergessen all fixed

[MorrisJobke]

@nickvergessen all fixed

But still CI is not happy:

............................................................. 6161 / 8125 ( 75%)
PHP Fatal error:  Cannot access protected property OCA\DAV\Server::$server in /drone/src/github.com/nextcloud/server/apps/dav/tests/unit/ServerTest.php on line 42

[nickvergessen]

Okay maybe you need to use invokePrivate in the test, when you don't want to make it public.

[MorrisJobke]

Okay maybe you need to use invokePrivate in the test, when you don't want to make it public.

Or for now simply drop that single change to have only the easier changes in here and for the specific one, that also touches tests you could open a separate PR ;)

[icewind1991]

Changed the test, the assert that used the property was unneeded

[MorrisJobke]

👍

[rullzer]

👍