Skip to content

Prevent reading key on SFTP stat bool #31531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

Prevent reading key on SFTP stat bool #31531

merged 1 commit into from
Mar 11, 2022

Conversation

@skjnldsv
Copy link
Member

Fix #26171

@skjnldsv
Prevent reading key on SFTP stat bool
e81eaf4 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Mar 11, 2022
@skjnldsv skjnldsv requested a review from a team March 11, 2022 09:55
@skjnldsv skjnldsv self-assigned this Mar 11, 2022
@skjnldsv skjnldsv requested review from PVince81, come-nc and icewind1991 and removed request for a team March 11, 2022 09:55
@skjnldsv
Copy link
Member Author

/backport to stable23

@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv
Copy link
Member Author

/backport to stable21

@skjnldsv skjnldsv requested a review from CarlSchwan March 11, 2022 09:56
PVince81
PVince81 approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CarlSchwan
CarlSchwan approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the first time we had this issue :/

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 11, 2022
@skjnldsv skjnldsv merged commit bcb1fc5 into master Mar 11, 2022
@skjnldsv skjnldsv deleted the fix/sftp-offset branch March 11, 2022 15:02
This was referenced Mar 11, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: external storage

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Error: Trying to access array offset on value of type bool at /var/www/nextcloud/apps/files_external/lib/Lib/Storage/SFTP.php on line 331 and 335

4 participants

@skjnldsv @PVince81 @CarlSchwan