Ignore errors when searching for bundled preview #31380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an odt file is xml and not zip, it would throw a ValueError. It will now just ignore this file and return null for the preview. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/opendocument-preview-avoid-errors
branch
from
c1a57e6 to
13c1120
Compare
come-nc
requested review from
a team,
ArtificialOwl,
juliusknorr and
nickvergessen
and removed request for
a team
juliusknorr
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
So far I've only seen full-XML office files using a different file ending (.fodt for example) which would the not be handled due to a different mime type (https://github.com/nextcloud/server/pull/29157/files#diff-f89544ac76d4f0e2cd70b4979d625b3992a72fa26c6f0b5fe92ec0364b9716e9R197-R200)
However makes sense to handle those errors more gracefully, especially if such files exist out there.
nickvergessen
approved these changes
Mar 1, 2022
come-nc
added
4. to release
|
backports? |
|
/backport to stable23 |
|
/backport to stable22 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an odt file is xml and not zip, it would throw a ValueError.
It will now just ignore this file and return null for the preview.
Fix #25340
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com