Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 26, 2022

For testing:

  1. share a single picture or audio file and select hideDownload
  2. open the link
  3. right-click (or long press on Android) on the image or audio controls

Before this change:

  1. See the default Browser options of which one is to download the file

After this change:

  1. The default Browser options are gone

I Verified that it works on:

  • Chromium based Browser on Desktop
  • Chromium based Browser on Android

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing
docker run -it \
-e SERVER_BRANCH=enh/noid/prevent-right-click-for-hide-download \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Feb 26, 2022
@szaimen szaimen force-pushed the enh/noid/prevent-right-click-for-hide-download branch from 9db98da to a2735fe Compare February 26, 2022 13:42
@szaimen szaimen changed the title prevent right-click when hideDownload is enabled prevent default right-click options when hideDownload is enabled Feb 26, 2022
@szaimen szaimen marked this pull request as ready for review February 28, 2022 11:23
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 28, 2022
@szaimen szaimen requested review from a team, Pytal, artonge, jancborchardt, nimishavijay and skjnldsv and removed request for a team February 28, 2022 11:23
@szaimen
Copy link
Contributor Author

szaimen commented Feb 28, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Feb 28, 2022

/backport to stable22

@szaimen szaimen force-pushed the enh/noid/prevent-right-click-for-hide-download branch from a2735fe to bdce1e7 Compare February 28, 2022 11:28
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/prevent-right-click-for-hide-download branch from bdce1e7 to 40a51e0 Compare March 3, 2022 13:02
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv
Copy link
Member

skjnldsv commented Mar 3, 2022

Please double check the documentation and make sure we properly communicate that it's cosmetic only and everything display in a browser cannot be 100% prevented from screenshot, cache retrieval.. .etc ? :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish pending documentation This pull request needs an associated documentation update and removed 3. to review Waiting for reviews labels Mar 3, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Mar 3, 2022

Please double check the documentation and make sure we properly communicate that it's cosmetic only and everything display in a browser cannot be 100% prevented from screenshot, cache retrieval.. .etc ? :)

I can do that! Can you give me a pointer where in the documentation this should be added/written?

@skjnldsv
Copy link
Member

skjnldsv commented Mar 3, 2022

I can do that! Can you give me a pointer where in the documentation this should be added/written?

Here maybe? https://docs.nextcloud.com/server/latest/user_manual/en/files/sharing.html

@szaimen
Copy link
Contributor Author

szaimen commented Mar 3, 2022

looks good! will do probably do on monday... is there also a dev documentation on this? (public pages)

@szaimen szaimen restored the enh/noid/prevent-right-click-for-hide-download branch March 3, 2022 16:18
@skjnldsv skjnldsv deleted the enh/noid/prevent-right-click-for-hide-download branch March 3, 2022 16:19
@skjnldsv skjnldsv removed the pending documentation This pull request needs an associated documentation update label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants