Add Nextcloud docs link to OPcache recommends #31267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added
enhancement
3. to review
8 tasks
CarlSchwan
approved these changes
Feb 18, 2022
MichaIng
force-pushed
the
enh/docs-link-for-opcache-recommends
branch
2 times, most recently
from
9314866 to
c905b9a
Compare
|
/rebase |
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list. Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend. Signed-off-by: MichaIng <micha@dietpi.com>
nextcloud-command
force-pushed
the
enh/docs-link-for-opcache-recommends
branch
from
c905b9a to
5ac91f1
Compare
szaimen
approved these changes
Mar 3, 2022
|
/backport to stable23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.
There have been a number of reports from users where the default 8 MiB interned strings buffer was full, in rare cases even 16 MiB were not sufficient (ignoring the cases where Nextcloud is not the only website on the same OPcache instance). The recommendation is accurate since a full interned strings buffer means that the full potential performance benefit of OPcache is not reached. I will extend the documentation to cover the interned strings buffer and add a small section about best practice to apply PHP settings. However, if we get more negative feedback about interned strings buffer in particular, we may need to reconsider whether measuring/showing it or not show it when 16 MiB or more are applied already.