Skip to content

fix overlapping buttons in apps-management #31090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix overlapping buttons in apps-management #31090

merged 1 commit into from
Feb 11, 2022

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 9, 2022 •
edited
Loading

Fix #31069

After:

image

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/31069/fix-overlapping-buttons-apps-management \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 2. developing Work in progress labels Feb 9, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Feb 9, 2022
@szaimen szaimen force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from f334139 to 972e837 Compare February 9, 2022 14:36
@nextcloud-command nextcloud-command force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from 972e837 to 5c5390a Compare February 9, 2022 14:53
@szaimen szaimen force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from 5c5390a to 395921d Compare February 9, 2022 15:14
@nextcloud-command nextcloud-command force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from 395921d to fec443b Compare February 9, 2022 15:38
@szaimen szaimen force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch 2 times, most recently from 3b7a227 to 74d8345 Compare February 9, 2022 15:47
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 9, 2022
@szaimen szaimen marked this pull request as ready for review February 9, 2022 15:48
@szaimen szaimen changed the title try to fix overlapping buttons in apps-management fix overlapping buttons in apps-management Feb 9, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2022

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from 74d8345 to e81b515 Compare February 9, 2022 16:14
@GretaD
Copy link
Contributor

GretaD commented Feb 9, 2022 •
edited
Loading

Looks ok, but i would propose to be aligned with the text.

@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2022

Looks ok, but i would propose to be aligned with the text.

What shall be aligned?

@GretaD
Copy link
Contributor

GretaD commented Feb 10, 2022

Looks ok, but i would propose to be aligned with the text.

What shall be aligned?

sorry :) i meant the text that you added to be aligned with the toggle menu

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 10, 2022
PVince81
PVince81 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@szaimen still developing ?

@szaimen szaimen force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from e81b515 to c4a3758 Compare February 10, 2022 19:50
@szaimen
Copy link
Contributor Author

szaimen commented Feb 10, 2022

/compile amend /

@szaimen @nextcloud-command
try to fix overlapping buttons in apps-management
d460c37 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/31069/fix-overlapping-buttons-apps-management branch from c4a3758 to d460c37 Compare February 10, 2022 20:27
@szaimen
Copy link
Contributor Author

szaimen commented Feb 10, 2022

sorry :) i meant the text that you added to be aligned with the toggle menu

done and updated the screenshot :)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 10, 2022
GretaD
GretaD approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didnt test it

@szaimen szaimen merged commit fbf260f into master Feb 11, 2022
@szaimen szaimen deleted the fix/31069/fix-overlapping-buttons-apps-management branch February 11, 2022 10:16
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Feb 12, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Feb 12, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Feb 12, 2022

/backport to stable21

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Feb 12, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen szaimen restored the fix/31069/fix-overlapping-buttons-apps-management branch February 14, 2022 20:27
@szaimen szaimen mentioned this pull request Feb 14, 2022
Merged
@solracsf solracsf deleted the fix/31069/fix-overlapping-buttons-apps-management branch February 15, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@GretaD GretaD GretaD approved these changes

@Pytal Pytal Pytal approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

[Bug]: App navigation toggle overlaps content

5 participants

@szaimen @GretaD @PVince81 @Pytal