Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 3, 2022

Close #30962

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing
docker run -it \
-e SERVER_BRANCH=enh/30962/show-mail-server-settings-in-overview \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Feb 3, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Feb 3, 2022
@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch 4 times, most recently from 726888e to 2399c7d Compare February 3, 2022 11:45
@szaimen szaimen added 3. to review Waiting for reviews enhancement and removed 2. developing Work in progress labels Feb 3, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Feb 3, 2022

/backport to stable23

@szaimen szaimen requested review from a team, blizzz, nickvergessen and skjnldsv and removed request for a team and skjnldsv February 3, 2022 12:19
@szaimen szaimen marked this pull request as ready for review February 3, 2022 12:20
@szaimen szaimen requested a review from MichaIng February 3, 2022 12:20
@MichaIng
Copy link
Member

MichaIng commented Feb 3, 2022

setAppValue() adds a new database row, not a config.php value, right? I was thinking whether it could be even made a flag in the local cache. On the other hand the mail server test runs only once when mail settings are changed, so that the result needs to be made persistent, right? Theoretically setup checks could trigger a new test, but probably too much overhead. EDIT: Ah I see it requires a verification mail as well, not applicable to trigger by setup checks. Then a persistent flag in the database indeed seems to be best solution.

@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch 2 times, most recently from 0fb7812 to e50d1b1 Compare February 3, 2022 14:09
@szaimen szaimen requested a review from MichaIng February 3, 2022 14:10
@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch from 81c56e2 to 0801f74 Compare February 3, 2022 14:27
@szaimen szaimen requested review from Pytal and artonge February 3, 2022 14:40
@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch 4 times, most recently from 2a395e8 to 2de9992 Compare February 3, 2022 17:21
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch from 2de9992 to e10e816 Compare February 3, 2022 19:16
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/30962/show-mail-server-settings-in-overview branch from e10e816 to 445ab85 Compare February 3, 2022 19:41
@szaimen
Copy link
Contributor Author

szaimen commented Feb 3, 2022

acceptance-app-files-sharing failure unrelated

@szaimen szaimen merged commit 8d631a0 into master Feb 3, 2022
@szaimen szaimen deleted the enh/30962/show-mail-server-settings-in-overview branch February 3, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show in the admin overview if no mail server was configured

4 participants