Skip to content

Add deprecation notice to script & addScript func #30876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add deprecation notice to script & addScript func #30876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/legacy/OC_Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ private static function generatePath($application, $directory, $file) {
/**
* add a javascript file
*
* @deprecated 24.0.0
* @deprecated 24.0.0 - Use \OCP\Util::addScript
*
* @param string $application application id
* @param string|null $file filename
Expand Down
3 changes: 2 additions & 1 deletion lib/private/legacy/template/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ function print_unescaped($string) {
* they are coming from a template registration.
* Please consider moving them into the relevant controller
*
* @deprecated 24.0.0 - Use \OCP\Util::addScript
*
* @param string $app the appname
* @param string|string[] $file the filename,
* if an array is given it will add all scripts
* @deprecated 23.1.0
*/
function script($app, $file = null) {
if (is_array($file)) {
Expand Down