Fix hiding default share permissions header #30777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsamK
force-pushed
the
bugfix/hide-default-share-permissions-header
branch
from
2203e91 to
e81ce80
Compare
AsamK
force-pushed
the
bugfix/hide-default-share-permissions-header
branch
from
e81ce80 to
f01e0cf
Compare
Signed-off-by: Sebastian Scheibner <asamk@gmx.de>
Fixes nextcloud#17371 Signed-off-by: Sebastian Scheibner <asamk@gmx.de>
AsamK
force-pushed
the
bugfix/hide-default-share-permissions-header
branch
from
f01e0cf to
1ad2bf8
Compare
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #17371 by hiding
h3tags in addition toptags when the share API is disabled.It also adds a missing
ptag for the allowResharing checkbox, which also didn't get hidden. (The corresponding end tag already exists)