Allow writing audit log to syslog and systemdlog #30763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
enhancement
3. to review
nickvergessen
added
the
pending documentation
nickvergessen
requested review from
CarlSchwan,
ChristophWurst,
PVince81 and
skjnldsv
skjnldsv
reviewed
Jan 20, 2022
nickvergessen
force-pushed
the
feature/noid/allow-to-log-audit-to-syslog
branch
from
de188b9 to
b7e7b8d
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/noid/allow-to-log-audit-to-syslog
branch
from
b7e7b8d to
497c584
Compare
|
I think I'm lacking too much knowledge to give a proper review sorry :( |
blizzz
approved these changes
Jan 25, 2022
skjnldsv
approved these changes
Jan 25, 2022
|
/backport to stable23 |
|
/backport to stable22 |
|
Documentation was done in nextcloud/documentation#7984 |
nickvergessen
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you think we should backport this, be aware that it might change the logging, as audit currently always logs to file and with this patch it starts falling back to the normal logging which could be syslog and others.
We could also change this, but I think it would make the most sense.
Also on merge and after discussion of above issue the documentation in https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/logging_configuration.html#admin-audit-log needs a treatment