Merged
Conversation
CarlSchwan
requested review from
ArtificialOwl,
nickvergessen and
skjnldsv
and removed request for
a team
solracsf
approved these changes
Jan 18, 2022
szaimen
approved these changes
Jan 18, 2022
Member
Author
This wasn't backported due to some errors as far I can see in #30653 |
skjnldsv
approved these changes
Jan 18, 2022
Member
|
@CarlSchwan manual backports of #30653 have been pushed. |
Member
Author
|
Weird it seems like it didn't fix the tests on the server :( It worked locally. I will investigate a bit more |
nickvergessen
approved these changes
Jan 18, 2022
Member
It worked, but now tests of the settings app are failing |
Member
|
I guess the expected HTML here also needs adjusting: |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/tests-email
branch
from
825c2d8 to
7619dce
Compare
Member
Author
|
the static analysis issue is unrelated, fix in #30745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Schwan carl@carlschwan.eu