Fix loading of the text app in public shared links#30719
Merged
Conversation
Instead of doing the centering for the entire public content, only do it for the preview. This is more safe. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
nickvergessen
approved these changes
Jan 17, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Loading again, but there are still issues
mejo-
approved these changes
Jan 17, 2022
Member
|
@nickvergessen What kind of issues? |
Member
Author
The close button issue we already looked today in the call |
Member
|
@CarlSchwan Ok thanks. We're on it 😁. |
This was referenced Jan 17, 2022
|
The backport to stable21 failed. Please do this backport manually. |
MichaIng
pushed a commit
that referenced
this pull request
Jan 17, 2022
Fix loading of the text app in public shared links
Contributor
|
I don't think this needs to be backported to stable21. At least from what i saw cypress tests were still passing in stable21 - which indicates the problem probably did not exist there. |
Member
Author
|
Yeah, the problematic PR wasn't merged yet in stable21 due to merge conflict. And i'm probably just gonna close it |
Contributor
|
#30696 is the backport pr in question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing the centering for the entire public content, only do it
for the preview. This is more safe.
Signed-off-by: Carl Schwan carl@carlschwan.eu