Make Sabre File exception messages translatable

[Pytal]

See title 👆

[Pytal]

/backport to stable23

[Pytal]

/backport to stable22

[Pytal]

/backport to stable21

[CarlSchwan]

Could it be maybe possible to store $this->l10nFactory->get(Application::APP_ID) inside a property of the File class instead of calling this everytime?

[PVince81]

need to check with clients to make sure they don't happen to read the english messages to distinguish errors

@tobiasKaminsky

[tobiasKaminsky]

need to check with clients to make sure they don't happen to read the english messages to distinguish errors

Which endpoint is this? Then I can check with team.

[Pytal]

Which endpoint is this? Then I can check with team.

This class is only used within the dav app so https://github.com/nextcloud/server/blob/master/apps/dav/appinfo/routes.php probably contains all of them

[tobiasKaminsky]

This class is only used within the dav app so https://github.com/nextcloud/server/blob/master/apps/dav/appinfo/routes.php probably contains all of them

If this is true, then there is no problem as we do only use v1/direct, which should be handled without translations.

[Pytal]

If this is true, then there is no problem as we do only use v1/direct, which should be handled without translations.

IDE reports use only within dav app, can you confirm @PVince81?

[PVince81]

If this is true, then there is no problem as we do only use v1/direct, which should be handled without translations.

IDE reports use only within dav app, can you confirm @PVince81?

I'm not familiar with this route. You could try grepping through the release tarball if you want to be sure.

[Pytal]

I'm not familiar with this route. You could try grepping through the release tarball if you want to be sure.

grepped through release tarball and looks good, @tobiasKaminsky can you confirm that the exception strings aren't used on clients?

[tobiasKaminsky]

Strings are not used, but only shown, e.g. if direct endpoint fails. Then they might be either shown as is or a generic error message is shown.
In either case we do not rely on exact wording of those strings, but only display them.

[Pytal]

Rebased