Fix rendering app authors with homepage or email#30413
Merged
Conversation
ChristophWurst
added
bug
3. to review
tcitworld
approved these changes
Dec 27, 2021
ChristophWurst
requested review from
a team,
Pytal and
szaimen
and removed request for
a team
skjnldsv
approved these changes
Dec 27, 2021
ChristophWurst
added
4. to release
When the first author of an app doesn't have homepage/email attributes set in info.xml then any further author was rendered as `[object Object]` due to the complex XML node seralized to a JavaScript string. The logic was fixed so that it converts any of the authors to simple text. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/app-authors-with-homepage
branch
from
a3ac12a to
89dce4b
Compare
nextcloud-command
force-pushed
the
fix/app-authors-with-homepage
branch
from
89dce4b to
3202f3f
Compare
ChristophWurst
force-pushed
the
fix/app-authors-with-homepage
branch
from
3202f3f to
89dce4b
Compare
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
This was referenced Dec 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first author of an app doesn't have homepage/email attributes
set in info.xml then any further author was rendered as
[object Object]due to the complex XML node serialized to a JavaScript string.The logic was fixed so that it converts any of the authors to simple
text.
This can be tested in combination with nextcloud/contacts#2587This can be tested with the Contacts Interaction app shipped in server. The second commit adds the Groupware team as co-maintainer and this now renders as expected on the apps management page.
Before
After